stop removing backslashes in shell#5856
Merged
keith-turner merged 2 commits intoapache:2.1from Sep 5, 2025
Merged
Conversation
Contributor
Author
|
Created this as a draft because I am not sure what functionality this might break in jshell. Also this changes shell behavior that has been different since 2.1.0. Test this and it does work, the jline line reader no longer turns |
ddanielr
reviewed
Sep 3, 2025
Contributor
Author
|
Reworked this in commit 82900a9 to make Accumulo look for the jline option and set it. Test that commit by inserting the following data in jshell. Then made the following change in accumulo-env.sh JAVA_OPTS=(
'-XX:OnOutOfMemoryError=kill -9 %p'
'-XX:-OmitStackTraceInFastThrow'
'-Djava.net.preferIPv4Stack=true'
'-Dorg.jline.reader.props.disable-event-expansion=on'
"-Daccumulo.native.lib.path=${lib}/native"
"${accumulo_initial_opts[@]}"
)After that, ran the shell and jline is no longer removing |
ddanielr
approved these changes
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3367