Skip to content

Publish ActiveMQ 5.15.11 release#22

Closed
jbonofre wants to merge 1 commit into
apache:masterfrom
jbonofre:AMQ-51511-RELEASE
Closed

Publish ActiveMQ 5.15.11 release#22
jbonofre wants to merge 1 commit into
apache:masterfrom
jbonofre:AMQ-51511-RELEASE

Conversation

@jbonofre
Copy link
Copy Markdown
Member

@jbonofre jbonofre commented Dec 6, 2019

No description provided.

@jbonofre jbonofre requested a review from cshannon December 6, 2019 13:51
@clebertsuconic
Copy link
Copy Markdown
Contributor

@jbonofre did you build.. I don't see any HTML outputs.

You have to edit the .md and call build, and commit within.

if you're having trouble builindg for any environment.. you can always ask for help.

using the view option will also help you.

@jbonofre
Copy link
Copy Markdown
Member Author

jbonofre commented Dec 6, 2019

@clebertsuconic let me double check (I built AFAIR). Thanks.

@clebertsuconic
Copy link
Copy Markdown
Contributor

if you built, you forgot to add ./content to your build.

I see no ./content changes, which is what's served by the webservers.

@clebertsuconic
Copy link
Copy Markdown
Contributor

clebertsuconic commented Dec 6, 2019

by calling ./build.sh on your PR I see this changed output, which means in fact you did not built it.

if you're having trouble, someone can build for you.. but you would need to verify the output as well.

let me know how it goes please.

clebertsuconic$ git status
On branch 22
Your branch is up to date with 'upstream/pr/22'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	content/activemq-51511-release.html
	content/schema/core/activemq-core-5.15.11-schema.html
	content/schema/core/activemq-core-5.15.11-schema.html.asc
	content/schema/core/activemq-core-5.15.11-schema.html.asc.md5
	content/schema/core/activemq-core-5.15.11-schema.html.asc.sha1
	content/schema/core/activemq-core-5.15.11-schema.html.md5
	content/schema/core/activemq-core-5.15.11-schema.html.sha1
	content/schema/core/activemq-core-5.15.11.xsd
	content/schema/core/activemq-core-5.15.11.xsd.asc
	content/schema/core/activemq-core-5.15.11.xsd.asc.md5
	content/schema/core/activemq-core-5.15.11.xsd.asc.sha1
	content/schema/core/activemq-core-5.15.11.xsd.md5
	content/schema/core/activemq-core-5.15.11.xsd.sha1

@jbonofre
Copy link
Copy Markdown
Member Author

jbonofre commented Dec 6, 2019

@clebertsuconic you are right, I didn't commit the output. Let me fix that.

Copy link
Copy Markdown
Member

@gemmellr gemmellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't try out the build etc but noticed a few issues and a potential improvement while skimming the diff.


For a more detailed view of new features and bug fixes, see the [release notes](https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210&version=12345958)

> **Java 8 Required**
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given it has been years, it feels like it is past time this note could go away.

>
> The minimum Java version has been upgraded to Java 8.

Also see the previous [ActiveMQ 5.15.9 Release](activemq-5159-release)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Links to the wrong previous version.

@@ -0,0 +1,17 @@
<html>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is junk, its not an MD5 file but rather the HTML contents of a 404 error page. It doesn't seem like the MD5 of a signature is needed anyway.

@@ -0,0 +1,17 @@
<html>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is junk, its not an SHA1 file but rather the HTML contents of a 404 error page. It doesn't seem like the SHA1 of a signature is needed anyway.

@@ -0,0 +1,17 @@
<html>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto re junk content.

@@ -0,0 +1,17 @@
<html>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto re junk content.

@jbonofre
Copy link
Copy Markdown
Member Author

jbonofre commented Dec 9, 2019

@gemmellr thanks for your feedback. Fixing the issue (about the file, I checked, it was the same with the previous release as well, fixing).

@asfgit asfgit closed this in 04e882b Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants