[AMQ-9447] Added Logic to check underlying transport connector limits#1192
Closed
AM-19 wants to merge 1 commit intoapache:mainfrom
Closed
[AMQ-9447] Added Logic to check underlying transport connector limits#1192AM-19 wants to merge 1 commit intoapache:mainfrom
AM-19 wants to merge 1 commit intoapache:mainfrom
Conversation
Member
|
That's a good start, on Tcp transport. I will add additional more "specific" transport (like http/https/ws transport). |
Contributor
Author
|
Hello @jbonofre Have Re-opened as PR 1194 Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Team,
With Regards to Transport Connector, Have added a check based on the connection count.
Also in the ticket, With regards to JDBC Persistence Check, We may need to have JDBC persistence associated classes in activemq-broker,jar, Post that we can have a logic something like following:
if (brokerService != null && brokerService.getPersistenceAdapter() != null && brokerService.getPersistenceAdapter() instanceof JDBCPersistenceAdapter ) { JDBCPersistenceAdapter jdbcAdapter = (JDBCPersistenceAdapter) brokerService.getPersistenceAdapter(); String message = "Issue with Persistence layer"; try { ResultSet rs = null; Statement stmt = jdbcAdapter.getDataSource().getConnection().createStatement(); rs = stmt.executeQuery("SELECT 1"); String message = if(rs.next()) if(rs.getInt(1)!=1) answer.add(new HealthStatus("org.apache.activemq.store.jdbc.JDBCPersistenceAdapterIssue", "ERROR", message, jdbcAdapter.toString())); } catch(Exception e) { answer.add(new HealthStatus("org.apache.activemq.store.jdbc.JDBCPersistenceAdapterIssue", "ERROR", message, jdbcAdapter.toString())); } }Ive Tested the above and it works as expected. But again that would require whole jdbc persistence adapter code.