AMQ-6135 ActiveMQ HTTP module should support Openwire serialisation#165
Open
pbruski wants to merge 8 commits intoapache:mainfrom
Open
AMQ-6135 ActiveMQ HTTP module should support Openwire serialisation#165pbruski wants to merge 8 commits intoapache:mainfrom
pbruski wants to merge 8 commits intoapache:mainfrom
Conversation
added 8 commits
January 22, 2016 15:45
Member
|
IMHO, it should be better to have an http option to support openwire format. Something like: It would allow to support current marshalling and openwire marshalling. NB: if you don't reply to this PR quickly, this one will be closed. |
Contributor
or perhaps a wireformat.type=[xstream | openwire], etc. I think it would be good to deprecate xstream usage and either update the openwire generator to include static generated XML marshaling, or just favor openwire over http. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am submitting this on behalf of Atlassian, the appropriate CCLAs are in place.
We have that code running in production and we didn't have any problems reports.
I assumed rather strict backward compatibility and interoperability requirements, not sure if that's needed. Well, at least the interoperability should be there.
In any case, it's easier to have them removed than to implement them as an afterthought.