[#] Disable fail-fast in CI strategy to improve job resilience#1651
Merged
[#] Disable fail-fast in CI strategy to improve job resilience#1651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal here is to get Github to run the entire matrix till the end. The default for
fail-fastis true, so when one combination of [os,java] fails, Github will cancel all the other jobs.Because it's not stable at the minute, we want to have the full view of all the failures as quickly as possible so we can fix more than one at a time.
And when it's done, I think it makes sense to get a view on all env so we know if one test is failing in one env but not in the other one.