Replace Thread.sleep with Wait.waitFor in FailoverClusterTest#1679
Open
jeanouii wants to merge 1 commit intoapache:mainfrom
Open
Replace Thread.sleep with Wait.waitFor in FailoverClusterTest#1679jeanouii wants to merge 1 commit intoapache:mainfrom
jeanouii wants to merge 1 commit intoapache:mainfrom
Conversation
Thread.sleep(3000) is unreliable on slow CI machines for waiting on cluster formation and client rebalancing. Replace all sleep-based synchronization with Wait.waitFor polling: - testClusterConnectedAfterClients: poll for clients on multiple brokers - testClusterURIOptionsStrip: same polling for client rebalance - testClusterConnectedBeforeClients: poll for bridge formation, then poll for client failover after broker stop This also fixes AutoFailoverClusterTest which inherits these methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thread.sleep(3000) is unreliable on slow CI machines for waiting on cluster formation and client rebalancing. Replace all sleep-based synchronization with Wait.waitFor polling:
This also fixes AutoFailoverClusterTest which inherits these methods.