[#2005] Fix authorization check on removeDestination#2006
Open
mattrpav wants to merge 1 commit into
Open
Conversation
mattrpav
added this to
Apache ActiveMQ v5.19.7, Apache ActiveMQ v6.3.0 and Apache ActiveMQ v6.2.6
cshannon
previously approved these changes
May 12, 2026
Contributor
|
This looks ok to me as long as tests are good. I looked at the core logic changes and they look correct so that the short circuit now looks good (it short circuits on remove if the dest doesn't exist and short circuits on add if the dest already exists) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.