Skip to content

Lower default maxFrameSize to 10 MB in xml config#2166

Merged
cshannon merged 1 commit into
apache:mainfrom
cshannon:max-frame-size-default
Jul 1, 2026
Merged

Lower default maxFrameSize to 10 MB in xml config#2166
cshannon merged 1 commit into
apache:mainfrom
cshannon:max-frame-size-default

Conversation

@cshannon

@cshannon cshannon commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

The previous default was 100 MB but 10 MB makes more sense as a default, especially with maxInflatedDataSize defaulting to 100 MB.

This only adjusts the XML config for now, we could also change the java code default in another PR (right now there is no default it is just Long.MAX)

The previous default was 100 MB but 10 MB makes more sense as a default,
especially with maxInflatedDataSize defaulting to 100 MB.
@cshannon cshannon requested review from jbonofre and mattrpav July 1, 2026 11:49
@cshannon cshannon changed the title Lower default maxFrameSize to 100 MB in xml config Lower default maxFrameSize to 10 MB in xml config Jul 1, 2026
@cshannon cshannon self-assigned this Jul 1, 2026

@tabish121 tabish121 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cshannon cshannon merged commit 505f5a9 into apache:main Jul 1, 2026
9 of 10 checks passed
@cshannon cshannon deleted the max-frame-size-default branch July 1, 2026 21:55
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Apache ActiveMQ v6.3.0 Jul 1, 2026
cshannon added a commit that referenced this pull request Jul 2, 2026
The previous default was 100 MB but 10 MB makes more sense as a default,
especially with maxInflatedDataSize defaulting to 100 MB.

(cherry picked from commit 505f5a9)
cshannon added a commit that referenced this pull request Jul 2, 2026
The previous default was 100 MB but 10 MB makes more sense as a default,
especially with maxInflatedDataSize defaulting to 100 MB.

(cherry picked from commit 505f5a9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants