AMQ-8189 add wait time to CachedLDAPAuthorizationModuleTest#640
Closed
charlie-cyf wants to merge 2 commits intoapache:masterfrom
Closed
AMQ-8189 add wait time to CachedLDAPAuthorizationModuleTest#640charlie-cyf wants to merge 2 commits intoapache:masterfrom
charlie-cyf wants to merge 2 commits intoapache:masterfrom
Conversation
Member
|
@charlie-cyf can you please rebase/squash your two commits ? Thanks ! |
| } | ||
| } | ||
| }); | ||
| }, 30*60*1000); |
Contributor
There was a problem hiding this comment.
10 minutes seems like an unreasonable amount of time to wait for a single test. The CI build is super long already. Do you think it could be shorter?
Contributor
|
Sure, new PR: #641 |
Member
|
For the record, you don't have to create a new PR. You can simply update this one with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing
Tested on my local Github Actions CI run: https://github.com/charlie-cyf/activemq/runs/2190121520?check_suite_focus=true#step:7:870