AMQ-6148 re-using LDAP context for authentication#673
Closed
Dm-Chebotarskyi wants to merge 1 commit intoapache:mainfrom
Closed
AMQ-6148 re-using LDAP context for authentication#673Dm-Chebotarskyi wants to merge 1 commit intoapache:mainfrom
Dm-Chebotarskyi wants to merge 1 commit intoapache:mainfrom
Conversation
epytka
reviewed
Jun 24, 2021
| throw new NamingException("Empty username is not allowed"); | ||
| } | ||
| protected void openContext() throws NamingException { | ||
| if (context == null) { |
There was a problem hiding this comment.
Just to be consistent with deleteContext you could change to:
if (context != null) {
return;
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
LDAPLoginModule.javaTesting
Manual test authentication using LDAP
TBDIssue
https://issues.apache.org/jira/browse/AMQ-6148