AMQ-6148 Reusing LDAP context to avoid creating new connections #699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Please rebase, and take a look at the comments about moving some clean-up tasks to finally {} blocks instead to prevent leaks or deadlock. |
Contributor
Author
Hey Matt, thanks for the quick review. |
mattrpav
reviewed
Aug 24, 2022
activemq-jaas/src/main/java/org/apache/activemq/jaas/LDAPLoginModule.java
Outdated
Show resolved
Hide resolved
activemq-jaas/src/main/java/org/apache/activemq/jaas/LDAPLoginModule.java
Outdated
Show resolved
Hide resolved
Dm-Chebotarskyi
requested review from
mattrpav
and removed request for
jbonofre
mattrpav
requested changes
Sep 9, 2022
activemq-jaas/src/main/java/org/apache/activemq/jaas/LDAPLoginModule.java
Show resolved
Hide resolved
activemq-jaas/src/main/java/org/apache/activemq/jaas/LDAPLoginModule.java
Show resolved
Hide resolved
jbonofre
approved these changes
Oct 14, 2022
activemq-jaas/src/main/java/org/apache/activemq/jaas/LDAPLoginModule.java
Show resolved
Hide resolved
activemq-jaas/src/main/java/org/apache/activemq/jaas/LDAPLoginModule.java
Show resolved
Hide resolved
Member
|
@Dm-Chebotarskyi do you mind to squash the 9 commits in one and rebase ? If you prefer, I can do it myself and manually merge. Thoughts ? |
Contributor
Author
|
Thanks for the review @jbonofre . |
Member
|
@Dm-Chebotarskyi awesome ! Thank you so much ! Let me know if I can help on anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Re-using LDAP context for authentication. The context is created only once and re-used each time ActiveMQ server established connection with ActiveMQ clients.
Refactoring some code in LDAPLoginModule.java
This PR is based on fix introduced to Artemis: apache/artemis@f3a8619#diff-706fd9b54d2aed5a0ea5d28fa7c70f7ee733672f7e91d847137517e3b147d716
Testing
Manual test authentication using LDAP
Issue
https://issues.apache.org/jira/browse/AMQ-6148