Skip to content

AMQ-8530 - Update to geronimo-annotation_1.3_spec#796

Merged
cshannon merged 1 commit intoapache:mainfrom
cshannon:AMQ-8530
Mar 9, 2022
Merged

AMQ-8530 - Update to geronimo-annotation_1.3_spec#796
cshannon merged 1 commit intoapache:mainfrom
cshannon:AMQ-8530

Conversation

@cshannon
Copy link
Contributor

@cshannon cshannon commented Mar 8, 2022

No description provided.

@cshannon
Copy link
Contributor Author

cshannon commented Mar 8, 2022

This fixes MessageDestinationVirtualTopicTest as well as any other tests that might use @Resource for autowiring

@cshannon cshannon requested review from jbonofre and mattrpav March 8, 2022 16:32
Copy link
Contributor

@mattrpav mattrpav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cshannon can you add an update to the features-core in activemq-karaf?

@cshannon
Copy link
Contributor Author

cshannon commented Mar 8, 2022

@cshannon can you add an update to the features-core in activemq-karaf?

Yep I'll fix it, I only searched pom.xml for references but should have searched all files for the reference

@cshannon
Copy link
Contributor Author

cshannon commented Mar 8, 2022

@mattrpav - should be good now, i also missed a spot in common-bin.xml

@cshannon cshannon requested a review from mattrpav March 8, 2022 17:02
Copy link
Contributor

@mattrpav mattrpav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cshannon
Copy link
Contributor Author

cshannon commented Mar 9, 2022

Rebased and pushed again to re-run tests as CI seemed to crash.

@cshannon cshannon merged commit 2a07500 into apache:main Mar 9, 2022
@cshannon cshannon deleted the AMQ-8530 branch April 29, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants