[AMQ-9058] Upgrade javacc-maven-plugin to 3.0.1#900
Merged
mattrpav merged 1 commit intoapache:mainfrom Feb 3, 2023
mattrpav:AMQ-9058
Merged
[AMQ-9058] Upgrade javacc-maven-plugin to 3.0.1#900mattrpav merged 1 commit intoapache:mainfrom mattrpav:AMQ-9058
mattrpav merged 1 commit intoapache:mainfrom
mattrpav:AMQ-9058
Conversation
Contributor
Author
|
@cshannon can you give this a look over? The upgrade created some new warning messages. |
Member
|
JavaCC needs to generate new files, but it will not generate boilerplate files unless they aren't there already. Try deleting all files generated by JavaCC and then re-running JavaCC. |
Contributor
Author
|
@jbonofre yep, this cleared up. Either with a mvn clean like you suggested, or with the upgrade. Current output looks good |
cshannon
approved these changes
Feb 2, 2023
Contributor
cshannon
left a comment
There was a problem hiding this comment.
Looks good with the new output
jbonofre
approved these changes
Feb 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build warnings that need review