Skip to content

[AMQ-9058] Upgrade javacc-maven-plugin to 3.0.1#900

Merged
mattrpav merged 1 commit intoapache:mainfrom
mattrpav:AMQ-9058
Feb 3, 2023
Merged

[AMQ-9058] Upgrade javacc-maven-plugin to 3.0.1#900
mattrpav merged 1 commit intoapache:mainfrom
mattrpav:AMQ-9058

Conversation

@mattrpav
Copy link
Contributor

Build warnings that need review

Reading from file activemq/activemq-client/src/main/grammar/SelectorParser.jj . . .
Warning: Line 22, Column 3: Command line setting of "STATIC" modifies option value in file.
Warning: Line 23, Column 3: Command line setting of "UNICODE_INPUT" modifies option value in file.
Warning: Line 26, Column 3: Command line setting of "ERROR_REPORTING" modifies option value in file.
File "TokenMgrError.java" does not exist.  Will create one.
File "ParseException.java" does not exist.  Will create one.
File "Token.java" does not exist.  Will create one.
File "SimpleCharStream.java" does not exist.  Will create one.
Parser generated with 0 errors and 3 warnings.

@mattrpav mattrpav changed the title [AMQ-9058] Upgrade javacc-maven-plugin to 3.0.0 [AMQ-9058] Upgrade javacc-maven-plugin to 3.0.1 Feb 1, 2023
@mattrpav mattrpav requested a review from cshannon February 2, 2023 14:00
@mattrpav
Copy link
Contributor Author

mattrpav commented Feb 2, 2023

@cshannon can you give this a look over? The upgrade created some new warning messages.

@jbonofre jbonofre self-requested a review February 2, 2023 14:02
@jbonofre
Copy link
Member

jbonofre commented Feb 2, 2023

JavaCC needs to generate new files, but it will not generate boilerplate files unless they aren't there already. Try deleting all files generated by JavaCC and then re-running JavaCC.

@mattrpav
Copy link
Contributor Author

mattrpav commented Feb 2, 2023

@jbonofre yep, this cleared up. Either with a mvn clean like you suggested, or with the upgrade.

Current output looks good

Note: UNICODE_INPUT option is specified. Please make sure you create the parser/lexer using a Reader with the correct character encoding.
File "TokenMgrError.java" does not exist.  Will create one.
File "ParseException.java" does not exist.  Will create one.
File "Token.java" does not exist.  Will create one.
File "SimpleCharStream.java" does not exist.  Will create one.
Parser generated successful

@mattrpav mattrpav marked this pull request as ready for review February 2, 2023 18:24
Copy link
Contributor

@cshannon cshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with the new output

@mattrpav mattrpav merged commit ed9631f into apache:main Feb 3, 2023
@mattrpav mattrpav deleted the AMQ-9058 branch February 3, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants