Skip to content

Haversine trigonometric function added#1136

Closed
Allison-E wants to merge 2 commits intoapache:masterfrom
Allison-E:trig/haversin
Closed

Haversine trigonometric function added#1136
Allison-E wants to merge 2 commits intoapache:masterfrom
Allison-E:trig/haversin

Conversation

@Allison-E
Copy link
Contributor

More about the Haversine trigonometric function here.

@dehowef
Copy link
Member

dehowef commented Aug 15, 2023

Looks good, but can you remove the changes you have made to the .gitignore file? Those are personal config changes we don't want them pushed to the main branch. Thank you @Allison-E

@Allison-E
Copy link
Contributor Author

Looks good, but can you remove the changes you have made to the .gitignore file? Those are personal config changes we don't want them pushed to the main branch. Thank you @Allison-E

Thank you. I've reverted the changes made.

@jrgemignani
Copy link
Contributor

@Allison-E This PR needs to be rebased against the current master due to changes to the age--x.x.x.sql file.

@jrgemignani
Copy link
Contributor

@Allison-E This PR needs to be rebased against the current master due to changes to the age--x.x.x.sql file.

@Allison-E Two points -

  1. The age--x.x.x.sql file was split up, your PR includes it again. You need to put your new function into the appropriate sql file for it. See the Makefile to see how age--x.x.x.sql was broken up. You likely need to bring your local repo up-to-date.
  2. I don't see the haversin function here, I see a date function?

Copy link
Contributor

@jrgemignani jrgemignani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@Allison-E
Copy link
Contributor Author

Thanks for pointing that out, @jrgemignani. I've reviewed the changes. I'll work on it and push the correct thing tomorrow.

@jrgemignani
Copy link
Contributor

@Allison-E Any update?

@github-actions
Copy link

This PR is stale because it has been open 60 days with no activity. Remove "Abondoned" label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the Stale Stale issues/PRs label Jun 17, 2024
@github-actions
Copy link

github-actions bot commented Jul 1, 2024

This PR was closed because it has been stalled for further 14 days with no activity

@github-actions github-actions bot closed this Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

master Stale Stale issues/PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants