Extend EXPLAIN and add config param to switch transformation of property filter#1299
Merged
jrgemignani merged 1 commit intoapache:PG11from Oct 25, 2023
Merged
Conversation
…rty filter
* Explain command in the following format is supported
now:
`EXPLAIN (VERBOSE, COSTS OFF, FORMAT XML) ...`
Note that, this is basically Postgres' EXPLAIN command,
and the purpose of this is to support debugging and
regression tests.
* Add config param to switch transformation method of property filter
When the `age.enable_containment` parameter is on, the agtype
containment operator is used to transform property filter. When off,
access operator is used instead. The former case is preferable for
GIN index, and the later for BTREE expression index.
The idea of replacing containment with access operator in order to
support BTREE index is taken from a patch by Josh Innis.
A note on regression testing- although there are test cases for the
`age.enable_containment` parameter, sometimes it may be useful to
set this parameter before running any tests (not just the ones related
to it). For example, when the logic related to property transformation
changes. It can be set in the `age_regression.conf` file.
jrgemignani
approved these changes
Oct 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EXPLAIN (VERBOSE, COSTS OFF, FORMAT XML) ...Note that, this is basically Postgres' EXPLAIN command, and the purpose of this is to support debugging and regression tests.
When the
age.enable_containmentparameter is on, the agtype containment operator is used to transform property filter. When off, access operator is used instead. The former case is preferable for GIN index, and the later for BTREE expression index.The idea of replacing containment with access operator in order to support BTREE index is taken from a patch by Josh Innis.
A note on regression testing- although there are test cases for the
age.enable_containmentparameter, sometimes it may be useful to set this parameter before running any tests (not just the ones related to it). For example, when the logic related to property transformation changes. It can be set in theage_regression.conffile.