Implement Returnless Unions in Subqueries #1803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dehowef
requested review from
MuhammadTahaNaveed,
Zainab-Saad,
jrgemignani and
rafsun42
Added logic to support returnless unions in subqueries. Added regression tests to support this addition. Modified regression tests to capture more cases.
rafsun42
reviewed
May 2, 2024
jrgemignani
approved these changes
May 7, 2024
Contributor
jrgemignani
left a comment
jrgemignani
left a comment
There was a problem hiding this comment.
Good to go if @rafsun42's comment is resolved.
MuhammadTahaNaveed
added
the
override-stale
rafsun42
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added logic to support returnless unions in subqueries.
Added regression tests to support this addition. Modified regression tests to capture more cases.