Minor VLE and agtype_eq/ne performance updates (#1808) #1817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integrated datum_image_hash and datum_image_eq to the logic for the VLE edge property datum match. Additionally, both were added to agtype_eq and agtype_ne. The hope is that, for large datums, these routines will improve performance. No impact to regression tests.
jrgemignani
requested review from
MuhammadTahaNaveed,
Zainab-Saad,
dehowef and
rafsun42
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrated datum_image_hash and datum_image_eq to the logic for the VLE edge property datum match.
Additionally, both were added to agtype_eq and agtype_ne.
The hope is that, for large datums, these routines will improve performance.
No impact to regression tests.