Optimize id() and properties() field access #2284
Merged
+348
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: This PR was created with AI tools and a human.
Optimized id() and properties() field access on vertices and edges.
When accessing id(v) or properties(v) on a vertex, the system was
generating inefficient SQL that rebuilt the entire vertex agtype
before extracting the field:
age_id(_agtype_build_vertex(id, _label_name_from_table_oid(labels),
properties))
This forced full vertex reconstruction for every row, even though
the data was already available in table columns.
Added optimize_vertex_field_access() in cypher_expr.c to detect these
patterns and optimize them to direct column access:
- age_id(_agtype_build_vertex(id, ...)) → graphid_to_agtype(id)
- age_properties(_agtype_build_vertex(..., props)) → props
- age_id(_agtype_build_edge(id, ...)) → graphid_to_agtype(id)
- age_start_id(_agtype_build_edge(...)) → graphid_to_agtype(start_id)
- age_end_id(_agtype_build_edge(...)) → graphid_to_agtype(end_id)
- age_properties(_agtype_build_edge(...)) → props
Note: age_label() is intentionally not optimized due to complexity
of cstring-to-agtype string conversion.
Added regression tests in unified_vertex_table.sql to verify the
optimization works correctly for both vertices and edges.
modified: regress/expected/unified_vertex_table.out
modified: regress/sql/unified_vertex_table.sql
modified: src/backend/parser/cypher_expr.c
github-actions
bot
added
the
override-stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR was created with AI tools and a human.
Optimized id() and properties() field access on vertices and edges.
When accessing id(v) or properties(v) on a vertex, the system was generating inefficient SQL that rebuilt the entire vertex agtype before extracting the field:
age_id(_agtype_build_vertex(id, _label_name_from_table_oid(labels),
properties))
This forced full vertex reconstruction for every row, even though the data was already available in table columns.
Added optimize_vertex_field_access() in cypher_expr.c to detect these patterns and optimize them to direct column access:
Note: age_label() is intentionally not optimized due to complexity of cstring-to-agtype string conversion.
Added regression tests in unified_vertex_table.sql to verify the optimization works correctly for both vertices and edges.
modified: regress/expected/unified_vertex_table.out
modified: regress/sql/unified_vertex_table.sql
modified: src/backend/parser/cypher_expr.c