Add missing include for PR: Add index scan (#2351)#2379
Merged
muhammadshoaib merged 1 commit intoapache:masterfrom Apr 14, 2026
Merged
Add missing include for PR: Add index scan (#2351)#2379muhammadshoaib merged 1 commit intoapache:masterfrom
muhammadshoaib merged 1 commit intoapache:masterfrom
Conversation
The CI build did not fail the PR (we need to verify why and correct
it) due to the missing include -
src/backend/utils/adt/age_global_graph.c:273:25: error: implicit declaration of
function ‘namestrcpy’; did you mean ‘strcpy’? [-Wimplicit-function-declaration]
273 | namestrcpy(lval, NameStr(*label_name_ptr));
| ^~~~~~~~~~
| strcpy
The build still works as the linker was able to resolve it. This PR
will add it in to correct the error going forward.
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds the missing header include needed to declare namestrcpy, preventing implicit-function-declaration compiler errors in age_global_graph.c.
Changes:
- Include
utils/builtins.hinsrc/backend/utils/adt/age_global_graph.cto provide the declaration fornamestrcpy.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
@muhammadshoaib ty! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI build did not fail the PR (we need to verify why and correct it) due to the missing include -
src/backend/utils/adt/age_global_graph.c:273:25: error: implicit declaration of function ‘namestrcpy’; did you mean ‘strcpy’? [-Wimplicit-function-declaration]
273 | namestrcpy(lval, NameStr(*label_name_ptr));
| ^~~~~~~~~~
| strcpy
The build still works as the linker was able to resolve it. This PR will add it in to correct the error going forward.