Skip to content

[ Packaging for AGE ] added packaging scripts : control,rules,format#691

Merged
JoshInnis merged 2 commits intoapache:AGE_packagingfrom
sarthak-19:deb_packaging-sarthak
Mar 5, 2023
Merged

[ Packaging for AGE ] added packaging scripts : control,rules,format#691
JoshInnis merged 2 commits intoapache:AGE_packagingfrom
sarthak-19:deb_packaging-sarthak

Conversation

@sarthak-19
Copy link
Copy Markdown
Contributor

Clean the directory and added scripts for debian package build.
The deb file can be build using dpkg-buildpackage -b

debian/rules Outdated
#
#override_dh_auto_clean:
# +pg_buildext clean build-%v
#
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the dead code L#8 till L#23

@@ -0,0 +1 @@
include: https://salsa.debian.org/postgresql/postgresql-common/raw/master/gitlab/gitlab-ci.yml
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for this file and its incorrect

debian/control Outdated
Maintainer: Debian PostgreSQL Maintainers <team+postgresql@tracker.debian.org>
Uploaders:
Sarthak Jaiswal <sarthak@debian.org>,
Ahmar Zaidi <ahmar@debian.org>,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use AGE maintainer email address from L#22 till L#25

debian/control Outdated
Ahmar Zaidi <ahmar@debian.org>,
Build-Depends:
debhelper-compat (= 13),
postgresql-11 | postgresql-12,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Target only PG12

debian/control Outdated
Rules-Requires-Root: no
Homepage: https://age.apache.org
Vcs-Browser: https://salsa.debian.org/postgresql/age
Vcs-Git: https://salsa.debian.org/postgresql/age.git
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L#37,38 not correct and should removed or fixed

@sarthak-19
Copy link
Copy Markdown
Contributor Author

Made the suggested changes. Request for review and merge

Copy link
Copy Markdown
Contributor

@uhayat uhayat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@JoshInnis JoshInnis merged commit 08dab75 into apache:AGE_packaging Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants