Skip to content

[GDBMS_cypher] e(), date() and localtime() functions#698

Closed
GhostVaibhav wants to merge 5 commits intoapache:GDBMS_cypherfrom
GhostVaibhav:GDBMS_cypher_vaibhav_3
Closed

[GDBMS_cypher] e(), date() and localtime() functions#698
GhostVaibhav wants to merge 5 commits intoapache:GDBMS_cypherfrom
GhostVaibhav:GDBMS_cypher_vaibhav_3

Conversation

@GhostVaibhav
Copy link
Copy Markdown
Contributor

@GhostVaibhav GhostVaibhav commented Feb 21, 2023

This PR adds the following functions:

  • e()
  • localtime_c()
  • date()

@GhostVaibhav
Copy link
Copy Markdown
Contributor Author

The function localtime() is renamed as localtime_c() due to naming conflicts with the default functions present in Postgres.

@GhostVaibhav GhostVaibhav marked this pull request as ready for review February 25, 2023 11:57
@emotionbug
Copy link
Copy Markdown
Contributor

It's a good idea to write tests together so that you can communicate to the other person that the code is working the way you want it to and that this is what you intended.

@GhostVaibhav
Copy link
Copy Markdown
Contributor Author

Alright, that means to bundle certain testcases at the top of the respective functions as comments?

@emotionbug
Copy link
Copy Markdown
Contributor

emotionbug commented Mar 9, 2023

@emotionbug emotionbug self-requested a review March 9, 2023 06:52
@emotionbug emotionbug changed the title e(), date() and localtime() functions [GDBMS_cypher] e(), date() and localtime() functions Mar 14, 2023
@GhostVaibhav
Copy link
Copy Markdown
Contributor Author

GhostVaibhav commented Apr 2, 2023

Added tests for the e() function [b383661] and the date() function [ea9364f]. Need assistance for writing tests for localtime_c().

@jrgemignani jrgemignani deleted the branch apache:GDBMS_cypher August 8, 2023 18:30
@jrgemignani jrgemignani closed this Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants