Skip to content

Apache Age Swift Driver: Methods added to check for the graph and Readme updated#726

Closed
FahadZaheerfzr wants to merge 2 commits intoapache:AGE_driver_swiftfrom
FahadZaheerfzr:AGE_driver_swift
Closed

Apache Age Swift Driver: Methods added to check for the graph and Readme updated#726
FahadZaheerfzr wants to merge 2 commits intoapache:AGE_driver_swiftfrom
FahadZaheerfzr:AGE_driver_swift

Conversation

@FahadZaheerfzr
Copy link
Copy Markdown
Contributor

Added a method to check if the graph already exists otherwise create one. Added this method on start-up. Moreover added some description in the Readme file

@dehowef dehowef self-assigned this Mar 6, 2023
@dehowef
Copy link
Copy Markdown
Member

dehowef commented Mar 6, 2023

Hi Fahad, can you explain the changes made in setUpAge to me? In the file drivers/age-swift/Sources/age-swift/age.swift, at line 23.

@FahadZaheerfzr
Copy link
Copy Markdown
Contributor Author

FahadZaheerfzr commented Mar 6, 2023

Hi Fahad, can you explain the changes made in setUpAge to me? In the file drivers/age-swift/Sources/age-swift/age.swift, at line 23.

Alright, so on line 23 Previously only the connection was passed as the argument, now the graph name is also being passed to check if the graph already exists else it creates one.

@dehowef
Copy link
Copy Markdown
Member

dehowef commented Mar 13, 2023

Great. It looks like there was some white space added on lines 37 and 38 in the file drivers/age-swift/Sources/age-swift/age.swift. If you could go ahead and remove that, I think everything else looks good @FahadZaheerfzr

There were some whitespaces on line 37 and 38 in Age.swift file. These whitespaces are removed for code readability.
@FahadZaheerfzr
Copy link
Copy Markdown
Contributor Author

Done but now I can not squash my commits to one commit. Can you please squash them into one commit?

Great. It looks like there was some white space added on lines 37 and 38 in the file drivers/age-swift/Sources/age-swift/age.swift. If you could go ahead and remove that, I think everything else looks good @FahadZaheerfzr

@dehowef
Copy link
Copy Markdown
Member

dehowef commented Mar 14, 2023

I think you can squash it yourself. Please research how. @FahadZaheerfzr

@FahadZaheerfzr FahadZaheerfzr closed this by deleting the head repository Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants