Feat : Remove Unused DSN in python driver unittest#811
Closed
Munmud wants to merge 1 commit into
Closed
Conversation
dehowef
reviewed
Apr 18, 2023
dehowef
left a comment
dehowef
left a comment
Member
There was a problem hiding this comment.
I think this change unnecessary
Member
|
Also it's not a feature-- so the feature label (FEAT) is not the best here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made this pr as mentioned in issue #810
DSN is never used in the code. So deleting it might be a good choice for not to confuse users.