[Python driver] adding connect_timeout#937
Closed
Mghrabi wants to merge 1 commit intoapache:masterfrom
Closed
Conversation
dehowef
reviewed
May 22, 2023
Member
dehowef
left a comment
dehowef
left a comment
There was a problem hiding this comment.
Hey, I think it might be better to let the users kill the program if it hangs rather than have it terminate early on them. Thank you for your contribution though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connect_timeoutto files in samples and totest_age_py.pyto quit long-time failed connectionsReason for making the PR:
I went through an issue while trying to connect to a database and it failed for some reason (using a jupyter notebook), the cell that runs the connection request was running forever and without yielding any output as the connect_timeout is not set. By adding the connect_timeout long-time failed connections quit
Note: (FROM MY UNDERSTANDING) I think adding timeout is a good practice, especially for local connections which shouldn't take a long time to connect, that's why I made this PR anyway since it targets samples and test files.