Improvement for Jira 1870 - provide ability to search experiments by jobId in the experiment statistics tab under admin dashboard#225
Merged
DImuthuUpe merged 6 commits intodevelopfrom Jun 4, 2019
unknown repository
Merged
Improvement for Jira 1870 - provide ability to search experiments by jobId in the experiment statistics tab under admin dashboard#225DImuthuUpe merged 6 commits intodevelopfrom unknown repository
DImuthuUpe merged 6 commits intodevelopfrom
unknown repository
Conversation
…ent model thrift file where one JOB_ID experimentSearchField is added. Added JOB_ID search field in the searchExperiments service handler.
…ceptions and clean up the code.
…ceptions and clean up the code.
DImuthuUpe
requested changes
May 30, 2019
Contributor
DImuthuUpe
left a comment
DImuthuUpe
left a comment
There was a problem hiding this comment.
@shivamriky Overall, this is a good implementation. You managed to implement the feature with minimal changes. I have added few comments but I think those are minor concerns. Once you address them, let's merge this.
| $pageNo); | ||
| } catch (AuthorizationException $ae) { | ||
|
|
||
| Log::error("Experiment wasn't found", array("message" => $enf->getMessage(), "username" => Session::get("username"), "gateway_id" => Session::get("gateway_id"))); |
Contributor
There was a problem hiding this comment.
Change the error message. This is an authorization error
...a/org/apache/airavata/registry/core/repositories/expcatalog/ExperimentSummaryRepository.java
Show resolved
Hide resolved
ghost
deleted the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added functionality in the PGA to search experiments using the jobId. It uses an existing API function searchExperiment() to first search the experiments using a new field 'JobId'. This new field is added to the experiment_model.thrift file.
After searching the corresponding experimentid using jobid, the normal flow of information follows i.e, the experiment Id is used to search a detailed view of the experiment and then presented to the user.
The below screenshot displays the functionality.