Skip to content

Conversation

@msumit
Copy link
Contributor

@msumit msumit commented Apr 24, 2021

No description provided.

@msumit msumit requested review from houqp, kaxil and potiuk April 24, 2021 10:11
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small nits

setup.cfg Outdated
long_description_content_type = text/markdown
license = Apache License 2.0
project_urls =
Documentation=https://airflow.apache.org/docs/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Documentation=https://airflow.apache.org/docs/
Documentation=https://airflow.apache.org/docs/apache-airflow/stable/stable-rest-api-ref.html

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel we should have separate docs for the python-client so that we can also have an Updating guide

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coz https://airflow.apache.org/docs/apache-airflow/stable/stable-rest-api-ref.html has the version of the API and it might be confusing

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link is with "stable" and I think it is good as is - API is more of a property of Airflow not the client, so it conceptually belongs to Airflow.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But yeah, I agree at some point in time we might want to have "Updating guide" for the client. So I agree eventually we should have a section for clients like we have "providers" and "docker-stack" now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case we should likely have a completely separate "Airflow API" section and have sub-sections for:

1) API specs
2) Clients
    - Python 
    - Go ....

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly my point :)

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
setup.py Outdated

NAME = "apache-airflow-client"
VERSION = "1.0.0"
VERSION = "2.0.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaxil I think using ver 2.0.0 isn't correct, as we've already released 2.0.0, so the code in the master is post 2.0.0 cut. We might name it 2.0.0.dev or whatever it is in airflow master.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah: let's change it to 2.1.0.dev

@msumit msumit merged commit 1b5ca49 into apache:master Apr 25, 2021
@msumit msumit deleted the update_links branch April 25, 2021 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants