-
Notifications
You must be signed in to change notification settings - Fork 69
Update links in PyPi #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
potiuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small nits
setup.cfg
Outdated
| long_description_content_type = text/markdown | ||
| license = Apache License 2.0 | ||
| project_urls = | ||
| Documentation=https://airflow.apache.org/docs/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Documentation=https://airflow.apache.org/docs/ | |
| Documentation=https://airflow.apache.org/docs/apache-airflow/stable/stable-rest-api-ref.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel we should have separate docs for the python-client so that we can also have an Updating guide
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
coz https://airflow.apache.org/docs/apache-airflow/stable/stable-rest-api-ref.html has the version of the API and it might be confusing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link is with "stable" and I think it is good as is - API is more of a property of Airflow not the client, so it conceptually belongs to Airflow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But yeah, I agree at some point in time we might want to have "Updating guide" for the client. So I agree eventually we should have a section for clients like we have "providers" and "docker-stack" now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case we should likely have a completely separate "Airflow API" section and have sub-sections for:
1) API specs
2) Clients
- Python
- Go ....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly my point :)
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
setup.py
Outdated
|
|
||
| NAME = "apache-airflow-client" | ||
| VERSION = "1.0.0" | ||
| VERSION = "2.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaxil I think using ver 2.0.0 isn't correct, as we've already released 2.0.0, so the code in the master is post 2.0.0 cut. We might name it 2.0.0.dev or whatever it is in airflow master.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah: let's change it to 2.1.0.dev
No description provided.