Skip to content

Added integration-logos and updated integrations.json#596

Merged
potiuk merged 2 commits intoapache:mainfrom
rozza:integrations
May 19, 2022
Merged

Added integration-logos and updated integrations.json#596
potiuk merged 2 commits intoapache:mainfrom
rozza:integrations

Conversation

@rozza
Copy link
Contributor

@rozza rozza commented May 17, 2022

No description provided.

@rozza
Copy link
Contributor Author

rozza commented May 17, 2022

Refs: apache/airflow#23748

Updated the integrations.json file by running generate-integrations-json.py

@potiuk
Copy link
Member

potiuk commented May 17, 2022

@mik-laj - is this fine that this many new images are generated ? It looks a bit strange?

@rozza
Copy link
Contributor Author

rozza commented May 17, 2022

@mik-laj - is this fine that this many new images are generated ? It looks a bit strange?

It surprised me also - feel free to run the generate-integrations-json.py to verify. I think it might not have been
run after apache/airflow#13717 added in all the new logos.

Update: Confirmed last update of integrations.json was Dec 2020 - so before the apache/airflow#13717 work.

@potiuk
Copy link
Member

potiuk commented May 17, 2022

Actually there is a problem that you need to solve with installing and running pre-commit (it will lint and re-format .json properly for you once you run it on the last commit).

@rozza
Copy link
Contributor Author

rozza commented May 18, 2022

Ran the pre commit hook - json file now linted / reformat.

@potiuk
Copy link
Member

potiuk commented May 19, 2022

Looked at the generated artifact website and it DOES look better for the integrations.

@potiuk potiuk merged commit 2033f8a into apache:main May 19, 2022
@rozza rozza deleted the integrations branch May 20, 2022 08:40
potiuk pushed a commit that referenced this pull request Jun 17, 2023
* Added integration-logos and updated integrations.json

* Pre commit hook run
potiuk pushed a commit that referenced this pull request May 8, 2025
* Added integration-logos and updated integrations.json

* Pre commit hook run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants