Skip to content

feat(github): add issue and PR templates aligned with CONTRIBUTING.md#324

Merged
potiuk merged 1 commit into
apache:mainfrom
potiuk:feat/issue-pr-templates
May 26, 2026
Merged

feat(github): add issue and PR templates aligned with CONTRIBUTING.md#324
potiuk merged 1 commit into
apache:mainfrom
potiuk:feat/issue-pr-templates

Conversation

@potiuk
Copy link
Copy Markdown
Member

@potiuk potiuk commented May 26, 2026

Summary

  • Adds three issue templates (bug_report.yml, change_proposal.yml, config.yml) and one PR template (PULL_REQUEST_TEMPLATE.md) that operationalise the guidance landed in CONTRIBUTING.md (docs(contributing): rewrite for framework-as-a-whole audience #323).
  • The change_proposal.yml template is intent-first by design — required fields are what + why + which layer; how is explicitly out of scope at the issue stage and is left to the agentic loop on the eventual PR.
  • The PR template carries the ## Summary + ## Test plan shape documented in CONTRIBUTING.md, plus a Type-of-change checklist scoped to the framework's layer map and an explicit RFC-AI-0004 compliance checklist (six principles → six checkboxes).
  • config.yml disables blank issues, routes open-ended questions to Discussions, and routes adopter security vulnerabilities to the adopter project's security@ list per ASF policy (not here).

Type of change

  • Documentation (docs/, README.md, CONTRIBUTING.md) — issue / PR template scaffolding
  • CI / dev loop (prek, workflows, validators) — doctoc exclude tweak

Test plan

  • prek run --files .pre-commit-config.yaml .github/ISSUE_TEMPLATE/*.yml .github/PULL_REQUEST_TEMPLATE.md passes
  • Verified the PR template is no longer touched by doctoc after adding it to the exclude list — head of the file starts at the SPDX header, no TOC injected
  • Issue templates are GitHub Issue Forms YAML — render shape can be verified once merged via the New issue flow

Companion change in .pre-commit-config.yaml

GitHub pre-populates a new PR description with the template verbatim, so a doctoc-generated TOC becomes per-PR noise that the contributor has to delete by hand. Added \.github/PULL_REQUEST_TEMPLATE\.md to the doctoc exclude pattern.

Linked issues

Follows from #323 (CONTRIBUTING.md rewrite — landed).

🤖 Generated with Claude Code

Why: the framework didn't have issue or PR templates, so every new
issue and PR re-invented its own shape. That's particularly costly
for a framework with an intent-first authoring loop — vague issues
turn into vague agentic conversations that don't converge, and PRs
without an explicit RFC-AI-0004 compliance pass miss principles a
reviewer would otherwise catch.

The templates operationalise CONTRIBUTING.md's guidance:

- `bug_report.yml` — what's broken, which layer, repro, expected vs
  actual. Calls out that an eval fixture is the highest-signal
  evidence for a skill-behaviour bug.

- `change_proposal.yml` — intent-first by design. Required fields are
  *what* + *why* + which layer; *how* is explicitly out of scope for
  the issue and left to the agentic loop on the PR. Optional
  boundary-conditions and out-of-scope fields surface edges up front,
  saving a round-trip during implementation.

- `config.yml` — disables blank issues; routes open-ended questions
  to Discussions; routes adopter security vulnerabilities to the
  adopter project's `security@` list per ASF policy (NOT here).

- `PULL_REQUEST_TEMPLATE.md` — the ## Summary + ## Test plan shape
  documented in CONTRIBUTING.md, plus a Type-of-change checklist
  scoped to the framework's layer map and an RFC-AI-0004 compliance
  checklist (six principles → six checkboxes). The eval-fixture
  requirement for skill behaviour changes is called out explicitly.

Companion change to `.pre-commit-config.yaml`: add the PR template
to the doctoc exclude list. GitHub pre-populates a new PR
description with the template verbatim, so a doctoc-generated TOC
becomes per-PR noise the contributor has to delete by hand.
Copy link
Copy Markdown
Member

@choo121600 choo121600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE!

@potiuk potiuk merged commit 1218969 into apache:main May 26, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants