chore(ci): require pytest via tests-ok umbrella job#341
Merged
Conversation
Branch protection on `main` cannot use patterns for required status check names — GitHub's classic branch-protection and rulesets APIs both require exact-match `context` strings, so each entry in the `pytest` matrix in `tests.yml` previously needed its own line in `.asf.yaml`. That coupling caused two known issues: - PR apache#340 renames `pytest (skill-validator)` → `pytest (skill-and-tool-validator)` and cannot merge, because branch protection on `main` still requires the old context name (which no longer runs in CI after the rename). - The `pytest (agent-isolation)` matrix entry added in apache#339 was never added to `.asf.yaml` and is silently not gated. Add a `tests-ok` umbrella job in `tests.yml` that `needs:` the `pytest` matrix and fails unless every matrix entry succeeded. Replace all `pytest (...)` entries in `.asf.yaml` with the single `tests-ok` context. Adding, renaming, or removing matrix entries no longer touches `.asf.yaml`. Follow-up for apache#340: drop the `.asf.yaml` hunk (the line is gone on `main`) and rebase. Generated-by: Claude Code (Opus 4.7)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maincannot use patterns for required status check names — GitHub's classic branch-protection and rulesets APIs both require exact-matchcontextstrings, so each entry in thepytestmatrix intests.ymlpreviously needed its own line in.asf.yaml.pytest (skill-validator)→pytest (skill-and-tool-validator)and cannot merge, because branch protection onmainstill requires the old context name (which no longer runs in CI after the rename).pytest (agent-isolation)matrix entry added in feat(agent-isolation): add Python packaging and pytest test harness #339 was never added to.asf.yamland is silently not gated.tests-okumbrella job intests.ymlthatneeds:thepytestmatrix and fails unless every matrix entry succeeded.pytest (...)entries in.asf.yamlwith the singletests-okcontext. Adding, renaming, or removing matrix entries no longer touches.asf.yaml.Follow-up
.asf.yamlhunk (theskill-validator→skill-and-tool-validatorrename) and rebase — the line is gone onmainafter this PR merges.Test plan
pytest (<project>)matrix entries still required by branch protection onmainuntil this PR merges).tests-okjob appears in the checks list and passes.tests-okas the single pytest-related required check, and is mergeable when all matrix entries pass..asf.yamlchange.