Skip to content

refactor(skills): prefix skill name: frontmatter with magpie-#442

Merged
potiuk merged 1 commit into
apache:mainfrom
potiuk:refactor/magpie-skill-name-prefix
Jun 3, 2026
Merged

refactor(skills): prefix skill name: frontmatter with magpie-#442
potiuk merged 1 commit into
apache:mainfrom
potiuk:refactor/magpie-skill-name-prefix

Conversation

@potiuk
Copy link
Copy Markdown
Member

@potiuk potiuk commented Jun 3, 2026

Summary

  • All 38 framework skills install under a magpie- namespace prefix
    (e.g. skills/issue-triage.claude/skills/magpie-issue-triage),
    but each SKILL.md name: frontmatter still carried the bare
    directory name — a mismatch with the installed skill name. This
    aligns every name: with its installed magpie-<dir> name.
  • Adds a HARD validator check (validate_name_convention) enforcing
    name: magpie-<directory-name> for every SKILL.md, so the
    convention can't silently drift again.

Type of change

  • Skill change (.claude/skills/<name>/)
  • CI / dev loop (prek, workflows, validators)

Test plan

  • prek run --all-files passes (all hooks green on commit, incl.
    skill-and-tool-validate + workspace pytest)
  • uv run pytest for the validator: 218 passed (5 new tests in
    TestValidateNameConvention); ruff check + mypy clean
  • Scope is name:-only: directory names and the install-time
    symlink/prefix logic are untouched.

RFC-AI-0004 compliance

  • Vendor neutrality — placeholders preserved; no project names introduced

Notes for reviewers

  • The magpie- prefix is still applied at install time. This PR only
    makes the source name: match the installed name and adds a guard so
    the two can't diverge. No behaviour change to any skill, so no eval
    fixtures were needed.

Every framework skill installs under a `magpie-` namespace prefix
(e.g. skills/issue-triage -> .claude/skills/magpie-issue-triage),
but each SKILL.md `name:` frontmatter still carried the bare
directory name, mismatching the installed skill name. Align all 38
skills' `name:` fields with their installed `magpie-<dir>` name.

Teach the validator to enforce the convention: a new HARD check
(validate_name_convention) requires `name: magpie-<directory-name>`
for every SKILL.md, with unit tests and updated README + module
docstring.

Generated-by: Claude Code (Opus 4.8)
@potiuk potiuk merged commit d60cbca into apache:main Jun 3, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant