Postgres hook uses deprecated parameter from base_aws.py

[akennedy4155]

Apache Airflow Provider(s)

postgres

Versions of Apache Airflow Providers

Most recent

Apache Airflow version

2.2.3 (latest released)

Operating System

macOS Big Sur 11.3.1

Deployment

Astronomer

Deployment details

Nothing else needed here. The source means that this is deployment agnostic I believe.

What happened

Postgres hook calls AwsBaseHook, and uses the client_type parameter from the conn cached property. Using client_type as a parameter here is deprecated, and it should be specified as part of the class initialization I believe.

Warning message is: client_type is deprecated. Set client_type from class attribute.

What you expected to happen

No deprecated calls or warning messages.

How to reproduce

Use postgres_hook.get_iam_token

Anything else

No response

Are you willing to submit PR?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow this project's Code of Conduct

[eladkal]

I don't see the issue. The reference to client_type is OK

airflow/airflow/providers/postgres/hooks/postgres.py

Line 181 in 3b4c26e

aws_hook = AwsBaseHook(aws_conn_id, client_type='rds')

Can you provide example DAG to reproduce the warning?

[potiuk]

Converted it to a discussion until more information is provided. Please epxlain how to reproduce it @akennedy4155