[AIRFLOW-187][AIRFLOW-228][AIRFLOW-260][AIRFLOW-302] Many PR tool fixes#1642
Merged
asfgit merged 7 commits intoapache:masterfrom Jul 12, 2016
Merged
[AIRFLOW-187][AIRFLOW-228][AIRFLOW-260][AIRFLOW-302] Many PR tool fixes#1642asfgit merged 7 commits intoapache:masterfrom
asfgit merged 7 commits intoapache:masterfrom
Conversation
Previously, we always used the PR title as the squash commit subject. Now, if the squash contains only one commit, then we use the commit message for the squash commit message. If the squash contains more than one commit, we default to the old behavior (using the PR title). We still ask if the user wants to include the PR body, but we only ask if they want to include the individual commits if there was more than one.
If the filter matched no version names, it would return an empty list and the [0] index would fail.
If no version is found, the “.name” attribute can’t be accessed, causing a crash.
Previously, the “fail” function was called, which exited the entire program. By returning from this function, we allow the JIRA loop to resume and users can continue closing other issues.
Current coverage is 64.26%@@ master #1642 diff @@
==========================================
Files 122 122
Lines 8562 8562
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 5501 5502 +1
+ Misses 3061 3060 -1
Partials 0 0
|
Contributor
|
LGTM |
asfgit
pushed a commit
that referenced
this pull request
Jul 12, 2016
alekstorm
pushed a commit
to alekstorm/incubator-airflow
that referenced
this pull request
Jun 1, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Airflow Maintainers,
Please accept this PR that addresses the following issues:
cc @criccomini (closes your issue AIRFLOW-228)
cc @bolkedebruin (first shot at closing your issue AIRFLOW-302 "The Bolke Correction"):
Previously, we always used the PR title as the squash commit subject.
Now, if the squash contains only one commit, then we use the commit
message for the squash commit message. If the squash contains more than
one commit, we default to the old behavior (using the PR title). We
still ask if the user wants to include the PR body, but we only ask if
they want to include the individual commits if there was more than one.
I haven't squashed the PR because it contains a large number of small fixes that don't share a common cause.