Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
|
@potiuk , please add review for any change needed. |
docs/apache-airflow/administration-and-deployment/security/audit_logs.rst
Outdated
Show resolved
Hide resolved
docs/apache-airflow/administration-and-deployment/security/audit_logs.rst
Outdated
Show resolved
Hide resolved
josh-fell
left a comment
There was a problem hiding this comment.
Only a small formatting suggestion -- similar to a previous one -- but LGTM.
docs/apache-airflow/administration-and-deployment/security/audit_logs.rst
Outdated
Show resolved
Hide resolved
…it_logs.rst Co-authored-by: Josh Fell <48934154+josh-fell@users.noreply.github.com>
|
@rohan472000 Can you address the CI failures when you get a chance please? You should be able to run both static checks and the build docs processes locally with Breeze. |
@josh-fell pipx is installed but showing pipx command not found, means it is not on PATH, how to set its path, after following BREEZE.rst also I'm getting problem |
|
while installing BREEZE , I'm getting below error PS C:\pycharm\codes\airflow-repo-clone> pipx install -e ./dev/breeze |
You are on Windows. You should use backslashes and you shoudl use windows path specification which I guess is |
|
BTW @rohan472000 once you figure out the right way of using it, I would highly appreciate PR to our docs describing it to users like you who might not realize that |
wow.. I was thinking of same @potiuk , I figured out the way and doing checks, after this I will do that docs also. |
|
after running PS C:\pycharm\codes\airflow-repo-clone\airflow> breeze setup regenerate-command-images During handling of the above exception, another exception occurred: Traceback (most recent call last): |
|
Can you please report it as an issue - @rohan472000 (and any others you might encounter). Seems you are one of the 0.00N% of people who attempt to use In the meantime if you want to run this command please install WSEL2 and checkout your branch there - you will be able to run the command without any problems. |
When breeze is run on Windows it fails with FileNotFoundException when running uname during emulation check. This is now fixed alongside fixing TimeoutError misplacement - after moving it to local import, an exception triggered before importing it causes UnboundLocaalError. Related: apache#30405 (comment) Fixes: apache#30465
When breeze is run on Windows it fails with FileNotFoundException when running uname during emulation check. This is now fixed alongside fixing TimeoutError misplacement - after moving it to local import, an exception triggered before importing it causes UnboundLocaalError. Related: #30405 (comment) Fixes: #30465
|
@potiuk kindly approve workflow to run. |
|
@potiuk kindly review it. |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
--------- Co-authored-by: Josh Fell <48934154+josh-fell@users.noreply.github.com> (cherry picked from commit 9590398)
--------- Co-authored-by: Josh Fell <48934154+josh-fell@users.noreply.github.com>
When breeze is run on Windows it fails with FileNotFoundException when running uname during emulation check. This is now fixed alongside fixing TimeoutError misplacement - after moving it to local import, an exception triggered before importing it causes UnboundLocaalError. Related: apache/airflow#30405 (comment) Fixes: #30465 GitOrigin-RevId: 56ff116ab3a005a07d62adbb7a0bdc0443cf2b85
When breeze is run on Windows it fails with FileNotFoundException when running uname during emulation check. This is now fixed alongside fixing TimeoutError misplacement - after moving it to local import, an exception triggered before importing it causes UnboundLocaalError. Related: apache/airflow#30405 (comment) Fixes: #30465 GitOrigin-RevId: 56ff116ab3a005a07d62adbb7a0bdc0443cf2b85
When breeze is run on Windows it fails with FileNotFoundException when running uname during emulation check. This is now fixed alongside fixing TimeoutError misplacement - after moving it to local import, an exception triggered before importing it causes UnboundLocaalError. Related: apache/airflow#30405 (comment) Fixes: #30465 GitOrigin-RevId: 56ff116ab3a005a07d62adbb7a0bdc0443cf2b85
When breeze is run on Windows it fails with FileNotFoundException when running uname during emulation check. This is now fixed alongside fixing TimeoutError misplacement - after moving it to local import, an exception triggered before importing it causes UnboundLocaalError. Related: apache/airflow#30405 (comment) Fixes: #30465 GitOrigin-RevId: 56ff116ab3a005a07d62adbb7a0bdc0443cf2b85
When breeze is run on Windows it fails with FileNotFoundException when running uname during emulation check. This is now fixed alongside fixing TimeoutError misplacement - after moving it to local import, an exception triggered before importing it causes UnboundLocaalError. Related: apache/airflow#30405 (comment) Fixes: #30465 GitOrigin-RevId: 56ff116ab3a005a07d62adbb7a0bdc0443cf2b85
When breeze is run on Windows it fails with FileNotFoundException when running uname during emulation check. This is now fixed alongside fixing TimeoutError misplacement - after moving it to local import, an exception triggered before importing it causes UnboundLocaalError. Related: apache/airflow#30405 (comment) Fixes: #30465 GitOrigin-RevId: 56ff116ab3a005a07d62adbb7a0bdc0443cf2b85
When breeze is run on Windows it fails with FileNotFoundException when running uname during emulation check. This is now fixed alongside fixing TimeoutError misplacement - after moving it to local import, an exception triggered before importing it causes UnboundLocaalError. Related: apache/airflow#30405 (comment) Fixes: #30465 GitOrigin-RevId: 56ff116ab3a005a07d62adbb7a0bdc0443cf2b85
When breeze is run on Windows it fails with FileNotFoundException when running uname during emulation check. This is now fixed alongside fixing TimeoutError misplacement - after moving it to local import, an exception triggered before importing it causes UnboundLocaalError. Related: apache/airflow#30405 (comment) Fixes: #30465 GitOrigin-RevId: 56ff116ab3a005a07d62adbb7a0bdc0443cf2b85
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.