Skip to content

Trigger Dag requires a JSON conf but Dag Run view display a python dict #10519

@marcoaaguiar

Description

@marcoaaguiar

Apache Airflow version: 1.10.11

Kubernetes version (if you are using kubernetes) (use kubectl version):

Environment:

  • Cloud provider or hardware configuration:

  • OS (e.g. from /etc/os-release): Windows 10 WSL (Ubuntu18.04.4)

  • Kernel (e.g. uname -a): Linux DESKTOP-8IVSCHM 4.4.0-18362-Microsoft SLA Misses not being recorded #836-Microsoft Mon May 05 16:04:00 PST 2020 x86_64 x86_64 x86_64 GNU/Linux

  • Install tools:

  • Others:

What happened:

In the Trigger Dag view for a specific Dag, the view asks for JSON formatted object as inpunt.
In the Dag Runs view (list), it shows python formatted object in the Conf column.

Despite JSON and Python formating being quite similar they differ in respect to string quotation marks: json uses double-quotes(") and python uses single quote(').
This makes annoying to copy a previously used config to a new trigger.

What you expected to happen:

I would expect a consistent read/write of Dag Run configuration.
In particular require a Json in the Trigger Dag view, and display a Json in the DAG Runs view.

How to reproduce it:

  1. Trigger a DAG manually passing a Json dict {"test": "this is a test"}.
  2. Go to Dag Runs view, it shows as {'test': 'this is a test'}

Anything else we need to know:

This is not application breaking issue, more a quality of life/usability issue.
I imagine it would be a minor change and could be tagged as an first issue

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions