Skip to content

[AMORO-3344] Fix the misdirection to quick start page when jumping from a three-level directory#42

Merged
klion26 merged 1 commit intoapache:masterfrom
Jzjsnow:fix_misdirection_to_quick_start_page_when_jumping_from_a_three-level_directory
Dec 23, 2024
Merged

[AMORO-3344] Fix the misdirection to quick start page when jumping from a three-level directory#42
klion26 merged 1 commit intoapache:masterfrom
Jzjsnow:fix_misdirection_to_quick_start_page_when_jumping_from_a_three-level_directory

Conversation

@Jzjsnow
Copy link
Contributor

@Jzjsnow Jzjsnow commented Dec 9, 2024

apache/amoro#3344
Here, we set the “pre” attribute of the “Quickstart” navigation item to “relative”, so that every time we click on the Quickstart will start from the $.Site.BaseURL, i.e. $AMORO_HOMEPAGE/docs/$version. Therefore, the jump ../../quick-start/ will point to a fixed path: $AMORO_HOMEPAGE/quick-start, so that it is no longer affected by the user's current path (e.g. third-level directory).

I've tested it locally and it works.

@Jzjsnow
Copy link
Contributor Author

Jzjsnow commented Dec 9, 2024

The jump logic for “pre”=“relative” is defined in amoro-theme/layouts/partials/header.html:
{{ if eq .Pre "relative" }}{{ $.Site.BaseURL }}{{ .URL }}{{ else }}{{ .URL }}{{ end }}

Copy link
Member

@klion26 klion26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, verified it in my local env, and it looks fine. Will merge it if there are no more comments from the community.

@MarigWeizhi
Copy link

MarigWeizhi commented Dec 11, 2024

  • When you're on this page https://amoro.apache.org/docs/0.6.1/. There are just latest and 0.6.1 on the docs and you get a similar error if you try to select the latest version.

  • Similarly, when you are under the 0.7.0 version of the documentation, the docs are only for latest, 0.7.0-incubating, 0.6.1, without 0.7.1.

微信截图_20241211185541

@klion26
Copy link
Member

klion26 commented Dec 20, 2024

@MarigWeizhi thanks for the review, seems there is something wrong with the docs part, there seem two problems:

  1. when the user clicks a specified version -- we say it A here , it would not show the version after A -- Seems other ASF projects like Flink show the same behavior, current Flink latest version is 1.20, If I go to version 1.17, it would not show version after 1.17
    image

  2. The' latest' version URL is wrong when we are on 0.6.1. it should be https://amoro.apache.org/docs/latest/, currently it is https://amoro.apache.org/docs/lastest/

Do you want to file an issue and solve this, thanks.

@MarigWeizhi
Copy link

MarigWeizhi commented Dec 20, 2024

@MarigWeizhi thanks for the review, seems there is something wrong with the docs part, there seem two problems:

  1. when the user clicks a specified version -- we say it A here , it would not show the version after A -- Seems other ASF projects like Flink show the same behavior, current Flink latest version is 1.20, If I go to version 1.17, it would not show version after 1.17
    image
  2. The' latest' version URL is wrong when we are on 0.6.1. it should be https://amoro.apache.org/docs/latest/, currently it is https://amoro.apache.org/docs/lastest/

Do you want to file an issue and solve this, thanks.

@klion26 I can solve the problem of “latest” jumping to “lastest” in version 0.6.1.
Whether another issue needs to be addressed?

@klion26 klion26 merged commit d35b2d6 into apache:master Dec 23, 2024
@klion26
Copy link
Member

klion26 commented Dec 23, 2024

@Jzjsnow @MarigWeizhi thanks for the contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants