Skip to content

[Bug]: continually creating unused keep_file when committing for a mixed_hive table optimization #3684

@nicochen

Description

@nicochen

What happened?

For a mixed hive unpartitioned table, the commit operation would create a unused new folder and a .keep file in hive path if no new add data are expexted to be written into hive path. The operation seems meaningless and it won't not be cleand by maintance thread.

https://github.com/apache/amoro/blob/aa379e276055ea4faa9b18d0da60b4525af9fe64/amoro-format-mixed/amoro-mixed-hive/src/main/java/org/apache/amoro/hive/op/UpdateHiveFiles.java#L155C3-L160C6

Affects Versions

master

What table formats are you seeing the problem on?

Mixed-Hive

What engines are you seeing the problem on?

Optimizer

How to reproduce

Creating an optimization for an unpartitioned table triggers the problem.

Relevant log output

Anything else

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

  • I agree to follow this project's Code of Conduct

Metadata

Metadata

Assignees

No one assigned

    Labels

    type:bugSomething isn't working

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions