[ARCTIC-873][CORE]Fix bug:insert overwrite will throw exception#1182
Merged
baiyangtx merged 4 commits intoapache:masterfrom Mar 2, 2023
Merged
[ARCTIC-873][CORE]Fix bug:insert overwrite will throw exception#1182baiyangtx merged 4 commits intoapache:masterfrom
baiyangtx merged 4 commits intoapache:masterfrom
Conversation
baiyangtx
requested changes
Mar 2, 2023
added 2 commits
March 2, 2023 11:09
baiyangtx
approved these changes
Mar 2, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1182 +/- ##
=========================================
Coverage ? 52.78%
Complexity ? 524
=========================================
Files ? 43
Lines ? 3704
Branches ? 354
=========================================
Hits ? 1955
Misses ? 1620
Partials ? 129
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
baiyangtx
pushed a commit
that referenced
this pull request
Mar 2, 2023
* fix overwrite * fix overwrite * fix overwrite * fix overwrite --------- Co-authored-by: jinsilei <jinsilei@corp.netease.com> (cherry picked from commit d5db96a) Signed-off-by: BaiyangTX <xiangnebula@163.com>
zhoujinsong
pushed a commit
that referenced
this pull request
May 31, 2023
* fix overwrite * fix overwrite * fix overwrite * fix overwrite --------- Co-authored-by: jinsilei <jinsilei@corp.netease.com>
ShawHee
pushed a commit
to ShawHee/arctic
that referenced
this pull request
Dec 29, 2023
…he#1182) * fix overwrite * fix overwrite * fix overwrite * fix overwrite --------- Co-authored-by: jinsilei <jinsilei@corp.netease.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
fix #873
Brief change log
change Map<StructLike, Partition> type to StructLikeMap
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation