Skip to content

[AMORO-2637] Enable return back to origin uri when relogin#2645

Merged
zhoujinsong merged 8 commits into
apache:masterfrom
tcodehuber:issue-2637
Apr 10, 2024
Merged

[AMORO-2637] Enable return back to origin uri when relogin#2645
zhoujinsong merged 8 commits into
apache:masterfrom
tcodehuber:issue-2637

Conversation

@tcodehuber
Copy link
Copy Markdown
Contributor

@tcodehuber tcodehuber commented Mar 18, 2024

Why are the changes needed?

Close #2637 .

Brief change log

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions Bot added module:ams-server Ams server module module:ams-dashboard Ams dashboard module labels Mar 18, 2024
@tcodehuber tcodehuber changed the title [AMORO-2637] Enable return back to origin uri when redirecting to log… [AMORO-2637] Enable return back to origin uri when relogin Mar 18, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.72%. Comparing base (92730de) to head (1f43e7d).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2645   +/-   ##
=========================================
  Coverage     34.71%   34.72%           
  Complexity     4521     4521           
=========================================
  Files           608      608           
  Lines         50980    50979    -1     
  Branches       6686     6686           
=========================================
  Hits          17700    17700           
+ Misses        31827    31826    -1     
  Partials       1453     1453           
Flag Coverage Δ
core 33.07% <ø> (+<0.01%) ⬆️
trino 50.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread ams/server/src/main/java/com/netease/arctic/server/dashboard/DashboardServer.java Outdated
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.95%. Comparing base (882b78b) to head (2fc66cf).

Additional details and impacted files
@@              Coverage Diff              @@
##             master    #2645       +/-   ##
=============================================
+ Coverage     34.02%   50.95%   +16.93%     
+ Complexity     4364      590     -3774     
=============================================
  Files           604       46      -558     
  Lines         50754     4708    -46046     
  Branches       6673      513     -6160     
=============================================
- Hits          17269     2399    -14870     
+ Misses        32086     2084    -30002     
+ Partials       1399      225     -1174     
Flag Coverage Δ
core ?
trino 50.95% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@baiyangtx baiyangtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the dashboard module's codes are modified, please recompile the project frontend

@baiyangtx
Copy link
Copy Markdown
Contributor

@minteliuwm PTAL

@tcodehuber
Copy link
Copy Markdown
Contributor Author

If the dashboard module's codes are modified, please recompile the project frontend

Now the front end can automatically submit the built files through the Maven plugin.

Copy link
Copy Markdown
Contributor

@minteliuwm minteliuwm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tcodehuber tcodehuber requested a review from minteliuwm April 8, 2024 09:49
Copy link
Copy Markdown
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zhoujinsong zhoujinsong merged commit 6ef7171 into apache:master Apr 10, 2024
@zhoujinsong zhoujinsong mentioned this pull request Jun 25, 2024
66 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:ams-dashboard Ams dashboard module module:ams-server Ams server module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement]: Enable returnUrl parameter when redirecting to login page

6 participants