Skip to content

[Hotfix] Fix the Chinese characters in the code#2784

Merged
tcodehuber merged 2 commits into
apache:masterfrom
jiamin13579:hotfix-1461
Apr 25, 2024
Merged

[Hotfix] Fix the Chinese characters in the code#2784
tcodehuber merged 2 commits into
apache:masterfrom
jiamin13579:hotfix-1461

Conversation

@jiamin13579
Copy link
Copy Markdown
Contributor

@jiamin13579 jiamin13579 commented Apr 25, 2024

Why are the changes needed?

In this code snippet, "36524" represents a specific numerical value, which actually denotes the total number of days in four years. This is because in the Gregorian calendar, a leap year occurs every four years. Therefore, "36524" signifies the total number of days in four years.

Brief change log

  • Modify the Chinese characters to "36524".

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions Bot added the module:mixed-flink Flink moduel for Mixed Format label Apr 25, 2024
@jiamin13579 jiamin13579 changed the title [hot-fix] Fix the Chinese characters in the code to the number '1461' [HotFix] Fix the Chinese characters in the code to the number '1461' Apr 25, 2024
@jiamin13579 jiamin13579 changed the title [HotFix] Fix the Chinese characters in the code to the number '1461' [Hotfix] Fix the Chinese characters in the code Apr 25, 2024
Copy link
Copy Markdown
Contributor

@zhongqishang zhongqishang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution.

Copy link
Copy Markdown
Contributor

@tcodehuber tcodehuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tcodehuber tcodehuber merged commit 5bca243 into apache:master Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:mixed-flink Flink moduel for Mixed Format

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants