Skip to content

[Improvement] Add NOTICE-binary & LICENSE-binary for binary release#2985

Merged
zhoujinsong merged 4 commits intoapache:masterfrom
zhoujinsong:add-binary-LICENSE-NOTICE
Jul 1, 2024
Merged

[Improvement] Add NOTICE-binary & LICENSE-binary for binary release#2985
zhoujinsong merged 4 commits intoapache:masterfrom
zhoujinsong:add-binary-LICENSE-NOTICE

Conversation

@zhoujinsong
Copy link
Copy Markdown
Contributor

Why are the changes needed?

Amoro binary file should have its own LICENSE and NOTICE file.

Brief change log

  • Add NOTICE-binary & LICENSE-binary.
  • Make the junit dependencies to the test scope.
  • Add some tools to collect license and notice information.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@github-actions github-actions bot added module:mixed-spark Spark module for Mixed Format type:infra type:build labels Jul 1, 2024
Copy link
Copy Markdown
Contributor

@xxubai xxubai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@zhouxinyu zhouxinyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@zhoujinsong zhoujinsong merged commit 0257da4 into apache:master Jul 1, 2024
@zhoujinsong zhoujinsong deleted the add-binary-LICENSE-NOTICE branch July 1, 2024 09:56
zhoujinsong added a commit that referenced this pull request Jul 11, 2024
…2985)

* Add NOTICE-binary & LICENSE-binary files

* Remove useless plugin

* Rollback dependency change

* Fix rat plugin check rules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants