Skip to content

[Draft][AMORO-3019][BUGFIX]Flink Using Unified Catalog to read/write iceberg table will encounter Kerberos Problem#3020

Closed
lklhdu wants to merge 5 commits intoapache:masterfrom
lklhdu:fix-iceberg-krb
Closed

[Draft][AMORO-3019][BUGFIX]Flink Using Unified Catalog to read/write iceberg table will encounter Kerberos Problem#3020
lklhdu wants to merge 5 commits intoapache:masterfrom
lklhdu:fix-iceberg-krb

Conversation

@lklhdu
Copy link
Contributor

@lklhdu lklhdu commented Jul 10, 2024

Why are the changes needed?

Fix #3019.

Brief change log

  • using Amoro TableMetaStore for kerberos authentication when read/write iceberg table

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added module:mixed-flink Flink moduel for Mixed Format type:build labels Jul 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.58%. Comparing base (08183b7) to head (998078a).
Report is 30 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (08183b7) and HEAD (998078a). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (08183b7) HEAD (998078a)
core 2 0
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3020      +/-   ##
============================================
- Coverage     32.85%   27.58%   -5.28%     
+ Complexity     3825     2484    -1341     
============================================
  Files           557      360     -197     
  Lines         46227    37117    -9110     
  Branches       6107     5372     -735     
============================================
- Hits          15189    10237    -4952     
+ Misses        29843    25919    -3924     
+ Partials       1195      961     -234     
Flag Coverage Δ
core ?
trino 27.58% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@czy006
Copy link
Contributor

czy006 commented Jul 17, 2024

@lklhdu Thanks for your contribution. Could you add some unit tests to this section or running screenshots

@zhoujinsong zhoujinsong marked this pull request as draft August 15, 2024 03:02
@github-actions
Copy link

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@amoro.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Sep 15, 2024
@github-actions
Copy link

This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:mixed-flink Flink moduel for Mixed Format stale type:build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Flink Using Unified Catalog to read/write iceberg table will encounter Kerberos Problem

4 participants