[AMORO-2787]: Remove memorySize option#3040
Merged
zhoujinsong merged 2 commits intoapache:masterfrom Jul 16, 2024
zhengkezhou1:ISSUE-2787
Merged
[AMORO-2787]: Remove memorySize option#3040zhoujinsong merged 2 commits intoapache:masterfrom zhengkezhou1:ISSUE-2787
memorySize option#3040zhoujinsong merged 2 commits intoapache:masterfrom
zhengkezhou1:ISSUE-2787
Conversation
memorySize optionmemorySize option
zhoujinsong
approved these changes
Jul 16, 2024
Contributor
zhoujinsong
left a comment
There was a problem hiding this comment.
LGTM.
Thanks for the contribution!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3040 +/- ##
=========================================
Coverage 32.80% 32.80%
Complexity 3827 3827
=========================================
Files 557 557
Lines 46194 46200 +6
Branches 6116 6120 +4
=========================================
+ Hits 15152 15155 +3
- Misses 29845 29848 +3
Partials 1197 1197
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Close #2787.
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation