Skip to content

[AMORO-2787]: Remove memorySize option#3040

Merged
zhoujinsong merged 2 commits intoapache:masterfrom
zhengkezhou1:ISSUE-2787
Jul 16, 2024
Merged

[AMORO-2787]: Remove memorySize option#3040
zhoujinsong merged 2 commits intoapache:masterfrom
zhengkezhou1:ISSUE-2787

Conversation

@zhengkezhou1
Copy link
Contributor

Why are the changes needed?

Close #2787.

Brief change log

  • amoro-ams/amoro-ams-optimizer/amoro-optimizer-common/src/main/java/org/apache/amoro/optimizer/common/OptimizerConfig

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? ( no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added the module:ams-optimizer AMS optimizer module label Jul 15, 2024
@zhengkezhou1 zhengkezhou1 changed the title [AMORO-2787] remove memorySize option [AMORO-2787]: Remove memorySize option Jul 15, 2024
Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for the contribution!

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.80%. Comparing base (f1fbfa1) to head (5b538ae).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3040   +/-   ##
=========================================
  Coverage     32.80%   32.80%           
  Complexity     3827     3827           
=========================================
  Files           557      557           
  Lines         46194    46200    +6     
  Branches       6116     6120    +4     
=========================================
+ Hits          15152    15155    +3     
- Misses        29845    29848    +3     
  Partials       1197     1197           
Flag Coverage Δ
core 32.80% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhoujinsong zhoujinsong merged commit a12f298 into apache:master Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:ams-optimizer AMS optimizer module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement]: Remove deprecated code that needs to be removed in 0.7

3 participants