Skip to content

[AMORO-3073]: Paimon Consumer adds the previous Snapshot Id Info (#3073)#3074

Merged
czy006 merged 1 commit intoapache:masterfrom
czy006:issuse/amoro-3073
Aug 5, 2024
Merged

[AMORO-3073]: Paimon Consumer adds the previous Snapshot Id Info (#3073)#3074
czy006 merged 1 commit intoapache:masterfrom
czy006:issuse/amoro-3073

Conversation

@czy006
Copy link
Contributor

@czy006 czy006 commented Jul 31, 2024

Why are the changes needed?

Close #3073.

Brief change log

  • Add Paimon Consumer AmoroSnapshotsOfTable of previous Snapshot Id Info

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not documented)

@github-actions github-actions bot added the module:ams-server Ams server module label Jul 31, 2024
@czy006
Copy link
Contributor Author

czy006 commented Jul 31, 2024

image

@czy006
Copy link
Contributor Author

czy006 commented Jul 31, 2024

#3054 UI with Paimon Consumer

Copy link
Contributor

@huyuanfeng2018 huyuanfeng2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@czy006 PTAL. I left some comments

@czy006 czy006 requested a review from huyuanfeng2018 August 1, 2024 01:55
@czy006
Copy link
Contributor Author

czy006 commented Aug 2, 2024

@zhoujinsong @huyuanfeng2018 After communicate with the Apache Paimon community, there is no interface for querying "current" consumption information in this part. We can only query NextSnapshotId-1 as some information of the current consumption Snapshot.

@czy006 czy006 changed the title [AMORO-3073]: Paimon Consumer adds the previous Snapshot Id Info (#3073) Draft[AMORO-3073]: Paimon Consumer adds the previous Snapshot Id Info (#3073) Aug 2, 2024
@czy006 czy006 force-pushed the issuse/amoro-3073 branch from f14bec8 to e00d9a0 Compare August 2, 2024 10:19
@czy006 czy006 changed the title Draft[AMORO-3073]: Paimon Consumer adds the previous Snapshot Id Info (#3073) [AMORO-3073]: Paimon Consumer adds the previous Snapshot Id Info (#3073) Aug 2, 2024
@czy006
Copy link
Contributor Author

czy006 commented Aug 2, 2024

image

@czy006 czy006 force-pushed the issuse/amoro-3073 branch from e00d9a0 to ebbf08b Compare August 3, 2024 15:00
@czy006 czy006 requested a review from huyuanfeng2018 August 4, 2024 02:48
Copy link
Contributor

@huyuanfeng2018 huyuanfeng2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@czy006 czy006 merged commit df81844 into apache:master Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:ams-server Ams server module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement]: Paimon Consumer adds the previous Snapshot Id Info

2 participants