Skip to content

[AMORO-3097] Improve the default configuration for AMS#3100

Merged
zhoujinsong merged 2 commits intoapache:masterfrom
mansonliwh:ams-default-ya
Aug 15, 2024
Merged

[AMORO-3097] Improve the default configuration for AMS#3100
zhoujinsong merged 2 commits intoapache:masterfrom
mansonliwh:ams-default-ya

Conversation

@mansonliwh
Copy link
Contributor

@mansonliwh mansonliwh commented Aug 15, 2024

Why are the changes needed?

Close #3097
The current default configurations of AMS are somewhat unreasonable, and we should improve them.

Brief change log

Turn off the sync-hive-tables service (change ams.sync-hive-tables.enabled to false).
Turn on the data-expiration service (change ams.data-expiration.enabled to true).
Add table-manifest-io.thread-count configuration example (add ams.table-manifest-io.thread-count and set default value to 20)
Add http-server.rest-auth-type configuration example (add ams.http-server.rest-auth-type and set default value to token)
Add terminal.result.limit configuration example(add terminal.result.limit and set default value to 1000)
Add terminal.stop-on-error configuration example(add terminal.stop-on-error and set default value to false)
Add terminal.session.timeout configuration example(add terminal.session.timeout and set default value to 30)
Add local.using-session-catalog-for-hive example (add terminal.local.using-session-catalog-for-hive and set default value to false)

Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mansonliwh Thanks for the contribution!
I left a small suggestion, PTAL.

@zhoujinsong zhoujinsong changed the title [Improvement] Improve the default configuration for AMS (#3097) [AMORO-3097] Improve the default configuration for AMS Aug 15, 2024
@zhoujinsong
Copy link
Contributor

zhoujinsong commented Aug 15, 2024

@mansonliwh
You can add a prefix in the PR title like [AMORO-3097] and Close #3097 in the PR description to link this PR to the related issue.

I have helped to modify it this time.

@zhoujinsong
Copy link
Contributor

cc @klion26
The default configuration of AMS had been improved.

@mansonliwh mansonliwh requested a review from zhoujinsong August 15, 2024 10:03
Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for the contribution!

@zhoujinsong zhoujinsong merged commit 1a6645f into apache:master Aug 15, 2024
@mansonliwh mansonliwh deleted the ams-default-ya branch October 15, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement]: Improve the default configuration for AMS

2 participants