[AMORO-3097] Improve the default configuration for AMS#3100
Merged
zhoujinsong merged 2 commits intoapache:masterfrom Aug 15, 2024
Merged
[AMORO-3097] Improve the default configuration for AMS#3100zhoujinsong merged 2 commits intoapache:masterfrom
zhoujinsong merged 2 commits intoapache:masterfrom
Conversation
zhoujinsong
reviewed
Aug 15, 2024
Contributor
zhoujinsong
left a comment
There was a problem hiding this comment.
@mansonliwh Thanks for the contribution!
I left a small suggestion, PTAL.
Contributor
|
@mansonliwh I have helped to modify it this time. |
Contributor
|
cc @klion26 |
zhoujinsong
approved these changes
Aug 15, 2024
Contributor
zhoujinsong
left a comment
There was a problem hiding this comment.
LGTM.
Thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Close #3097
The current default configurations of AMS are somewhat unreasonable, and we should improve them.
Brief change log
Turn off the sync-hive-tables service (change ams.sync-hive-tables.enabled to false).
Turn on the data-expiration service (change ams.data-expiration.enabled to true).
Add table-manifest-io.thread-count configuration example (add ams.table-manifest-io.thread-count and set default value to 20)
Add http-server.rest-auth-type configuration example (add ams.http-server.rest-auth-type and set default value to token)
Add terminal.result.limit configuration example(add terminal.result.limit and set default value to 1000)
Add terminal.stop-on-error configuration example(add terminal.stop-on-error and set default value to false)
Add terminal.session.timeout configuration example(add terminal.session.timeout and set default value to 30)
Add local.using-session-catalog-for-hive example (add terminal.local.using-session-catalog-for-hive and set default value to false)