[Improvement]: AMS frequently print warning logs of 'Unclosed ResolvingFileIO'#3124
Merged
zhoujinsong merged 3 commits intoapache:masterfrom Sep 2, 2024
Merged
[Improvement]: AMS frequently print warning logs of 'Unclosed ResolvingFileIO'#3124zhoujinsong merged 3 commits intoapache:masterfrom
zhoujinsong merged 3 commits intoapache:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3124 +/- ##
============================================
- Coverage 27.64% 27.18% -0.46%
+ Complexity 2496 2462 -34
============================================
Files 360 363 +3
Lines 37133 37471 +338
Branches 5372 5400 +28
============================================
- Hits 10265 10187 -78
- Misses 25908 26327 +419
+ Partials 960 957 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
czy006
approved these changes
Aug 22, 2024
Contributor
|
@tcodehuber Some conflicts may need to be fixed. |
Contributor
Author
Fixed. @zhoujinsong |
Contributor
|
Thanks for the contribution! @tcodehuber |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Close #2024 .
Brief change log
Tested OK in local env.

How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation