Skip to content

[Improvement]: AMS frequently print warning logs of 'Unclosed ResolvingFileIO'#3124

Merged
zhoujinsong merged 3 commits intoapache:masterfrom
tcodehuber:close-fileio
Sep 2, 2024
Merged

[Improvement]: AMS frequently print warning logs of 'Unclosed ResolvingFileIO'#3124
zhoujinsong merged 3 commits intoapache:masterfrom
tcodehuber:close-fileio

Conversation

@tcodehuber
Copy link
Contributor

Why are the changes needed?

Close #2024 .

Brief change log

Tested OK in local env.
image

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added the module:ams-server Ams server module label Aug 21, 2024
@tcodehuber tcodehuber changed the title [Improvement]: AMS frequently print warning logs of 'Unclosed ResolvingngFileIO' [Improvement]: AMS frequently print warning logs of 'Unclosed ResolvingFileIO' Aug 21, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.18%. Comparing base (9def89f) to head (b9024d9).
Report is 3 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3124      +/-   ##
============================================
- Coverage     27.64%   27.18%   -0.46%     
+ Complexity     2496     2462      -34     
============================================
  Files           360      363       +3     
  Lines         37133    37471     +338     
  Branches       5372     5400      +28     
============================================
- Hits          10265    10187      -78     
- Misses        25908    26327     +419     
+ Partials        960      957       -3     
Flag Coverage Δ
trino 27.18% <ø> (-0.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhoujinsong
Copy link
Contributor

@tcodehuber Some conflicts may need to be fixed.

@tcodehuber
Copy link
Contributor Author

@tcodehuber Some conflicts may need to be fixed.

Fixed. @zhoujinsong

@zhoujinsong zhoujinsong merged commit 365b272 into apache:master Sep 2, 2024
@zhoujinsong
Copy link
Contributor

Thanks for the contribution! @tcodehuber

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:ams-server Ams server module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement]: AMS frequently print warning logs of 'Unclosed ResolvingFileIO'

4 participants