[AMORO-3153]Modify the implementation class of the thrift server#3154
Merged
zhoujinsong merged 2 commits intoapache:masterfrom Sep 2, 2024
Merged
[AMORO-3153]Modify the implementation class of the thrift server#3154zhoujinsong merged 2 commits intoapache:masterfrom
zhoujinsong merged 2 commits intoapache:masterfrom
Conversation
Contributor
huyuanfeng2018
left a comment
huyuanfeng2018
left a comment
There was a problem hiding this comment.
Can you provide some screenshots or test cases to prove that this change can solve the problem? It seems that many people have encountered this problem.
Contributor
@engraving-knife works with me to solve this issue together. |
czy006
approved these changes
Sep 2, 2024
Contributor
|
Thanks for the work! @engraving-knife |
zhoujinsong
pushed a commit
that referenced
this pull request
Oct 11, 2024
Modify the implementation class of the thrift server Co-authored-by: xiaosefeng <xiaosefeng@tencent.com> Co-authored-by: Xavier Bai <xuba@apache.org> (cherry picked from commit 8207efc) Signed-off-by: zhoujinsong <zhoujinsong0505@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Close #3153.
Brief change log
-The implementation class of TServer has been modified.
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation