[AMORO-3145] Filter out info log for CodecPool in optimizer #3185
Merged
czy006 merged 1 commit intoapache:masterfrom Sep 10, 2024
Merged
[AMORO-3145] Filter out info log for CodecPool in optimizer #3185czy006 merged 1 commit intoapache:masterfrom
czy006 merged 1 commit intoapache:masterfrom
Conversation
Currently there will be many logs for (de)compressor from CodecPool, and seems there is no other meaningful info log from this class, so we change the log level from CodecPool from info to warn to filter out these logs This only affect the local optimizer, and user need to change the configuration if they use flink/spark optimzier.
Member
Author
|
cc @czy006 |
Member
Author
|
@czy006 thanks for the review and merging! |
zhoujinsong
pushed a commit
that referenced
this pull request
Oct 11, 2024
[AMORO-3145] Filter out info log for CodecPool Currently there will be many logs for (de)compressor from CodecPool, and seems there is no other meaningful info log from this class, so we change the log level from CodecPool from info to warn to filter out these logs This only affect the local optimizer, and user need to change the configuration if they use flink/spark optimzier. (cherry picked from commit b52f64d) Signed-off-by: zhoujinsong <zhoujinsong0505@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Close #3145 .
Brief change log
Currently there will be many logs for (de)compressor from CodecPool, and seems there is no other meaningful info log from this class, so we change
the log level from CodecPool from info to warn to filter out these logs
This only affect the local optimizer, and user need to change the configuration if they use flink/spark optimzier.
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Before the change
After the change
Documentation