Skip to content

[AMORO-3224] Compare min plan interval in optimizing config#3225

Merged
zhoujinsong merged 1 commit intoapache:masterfrom
zhoujinsong:fix-min-plan-interval-config
Sep 26, 2024
Merged

[AMORO-3224] Compare min plan interval in optimizing config#3225
zhoujinsong merged 1 commit intoapache:masterfrom
zhoujinsong:fix-min-plan-interval-config

Conversation

@zhoujinsong
Copy link
Copy Markdown
Contributor

Why are the changes needed?

Close #3224.

Brief change log

  • Compare min-plan-interval in OptimizingConfig#equals

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@zhoujinsong zhoujinsong merged commit 91a2dac into apache:master Sep 26, 2024
@zhoujinsong zhoujinsong deleted the fix-min-plan-interval-config branch September 26, 2024 09:43
@zhoujinsong
Copy link
Copy Markdown
Contributor Author

@czy006 Thanks for the review!

zhoujinsong added a commit that referenced this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot set self-optimizing.min-plan-interval table property dynamically

2 participants