Skip to content

[AMORO-3333] Include file copied from bitnami/charts into license#3353

Merged
baiyangtx merged 1 commit intoapache:masterfrom
klion26:improve-license
Dec 9, 2024
Merged

[AMORO-3333] Include file copied from bitnami/charts into license#3353
baiyangtx merged 1 commit intoapache:masterfrom
klion26:improve-license

Conversation

@klion26
Copy link
Member

@klion26 klion26 commented Dec 7, 2024

Why are the changes needed?

Close #3333 .

Brief change log

  • Add license for files copied from other repo(bitnami/charts)

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@klion26
Copy link
Member Author

klion26 commented Dec 7, 2024

Currently, this pr only includes the license for the copied file and doesn't touch the license-binary dir or the logic to collect the license for the final distribution.

@klion26 klion26 requested a review from zhoujinsong December 7, 2024 05:11
Copy link
Contributor

@baiyangtx baiyangtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baiyangtx baiyangtx merged commit 2298331 into apache:master Dec 9, 2024
@klion26
Copy link
Member Author

klion26 commented Dec 9, 2024

@baiyangtx thanks for the review and merging!

@klion26 klion26 deleted the improve-license branch December 9, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement]: Improve the LICENSE and NOTICE file

2 participants