[AMORO-3459][Improvement]: Obtain the master's service address based on service discovery, which requires writing the HTTP port to ZooKeeper#3462
Conversation
…on service discovery, which requires writing the HTTP port to ZooKeeper(apache#3459)
|
@czy006 I'm afraid that this change might break client compatibility, causing older versions of the client to fail to retrieve information correctly. We may need to consider the risks associated with the version upgrade. |
This is indeed a destructive upgrade. We have changed the metadata and zk address. Could we explain this in the documentation? Or do we have to enforce compatibility? @zhoujinsong |
Considering that the data stored in zk is ephemeral, this upgrade only requires the optimizer, client, and ams to be upgraded together without involving data migration. Can it be included in version 0.8? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3462 +/- ##
============================================
- Coverage 27.92% 27.92% -0.01%
- Complexity 3663 3666 +3
============================================
Files 603 603
Lines 49348 49354 +6
Branches 6367 6368 +1
============================================
Hits 13780 13780
- Misses 34598 34607 +9
+ Partials 970 967 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
We need to remind users to stop AMS and Optimizer, but I believe that most users will do it |
[AMORO-3459][Improvement]: Obtain the master's service address based on service discovery, which requires writing the HTTP port to ZooKeeper(#3459)
Why are the changes needed?
Close #3459.
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation