Skip to content

[AMORO-3459][Improvement]: Obtain the master's service address based on service discovery, which requires writing the HTTP port to ZooKeeper#3462

Merged
czy006 merged 6 commits intoapache:masterfrom
czy006:issues/AMORO-3459
Apr 27, 2025

Conversation

@czy006
Copy link
Contributor

@czy006 czy006 commented Mar 11, 2025

[AMORO-3459][Improvement]: Obtain the master's service address based on service discovery, which requires writing the HTTP port to ZooKeeper(#3459)

Why are the changes needed?

Close #3459.

Brief change log

  • Add AMS Rest Port in AmsServerInfo
  • AMSROOT Path change artic to amoro

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

…on service discovery, which requires writing the HTTP port to ZooKeeper(apache#3459)
@zhoujinsong
Copy link
Contributor

@czy006 I'm afraid that this change might break client compatibility, causing older versions of the client to fail to retrieve information correctly. We may need to consider the risks associated with the version upgrade.

@czy006
Copy link
Contributor Author

czy006 commented Mar 13, 2025

@czy006 I'm afraid that this change might break client compatibility, causing older versions of the client to fail to retrieve information correctly. We may need to consider the risks associated with the version upgrade.

This is indeed a destructive upgrade. We have changed the metadata and zk address. Could we explain this in the documentation? Or do we have to enforce compatibility? @zhoujinsong

@baiyangtx
Copy link
Contributor

@czy006 I'm afraid that this change might break client compatibility, causing older versions of the client to fail to retrieve information correctly. We may need to consider the risks associated with the version upgrade.

This is indeed a destructive upgrade. We have changed the metadata and zk address. Could we explain this in the documentation? Or do we have to enforce compatibility? @zhoujinsong

Considering that the data stored in zk is ephemeral, this upgrade only requires the optimizer, client, and ams to be upgraded together without involving data migration. Can it be included in version 0.8?

@zhoujinsong

@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 27.92%. Comparing base (f07990a) to head (b228b23).

Files with missing lines Patch % Lines
...in/java/org/apache/amoro/client/AmsServerInfo.java 0.00% 7 Missing ⚠️
...apache/amoro/server/HighAvailabilityContainer.java 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3462      +/-   ##
============================================
- Coverage     27.92%   27.92%   -0.01%     
- Complexity     3663     3666       +3     
============================================
  Files           603      603              
  Lines         49348    49354       +6     
  Branches       6367     6368       +1     
============================================
  Hits          13780    13780              
- Misses        34598    34607       +9     
+ Partials        970      967       -3     
Flag Coverage Δ
core 27.92% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@czy006
Copy link
Contributor Author

czy006 commented Mar 19, 2025

@czy006 I'm afraid that this change might break client compatibility, causing older versions of the client to fail to retrieve information correctly. We may need to consider the risks associated with the version upgrade.

This is indeed a destructive upgrade. We have changed the metadata and zk address. Could we explain this in the documentation? Or do we have to enforce compatibility? @zhoujinsong

Considering that the data stored in zk is ephemeral, this upgrade only requires the optimizer, client, and ams to be upgraded together without involving data migration. Can it be included in version 0.8?

@zhoujinsong

We need to remind users to stop AMS and Optimizer, but I believe that most users will do it

@czy006 czy006 merged commit fe49db5 into apache:master Apr 27, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement]: Obtain the master's service address based on service discovery, which requires writing the HTTP port to ZooKeeper

4 participants

Comments